Improve graph builder start up #5484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
changed the title
leonardehrenfried
previously approved these changes
Nov 7, 2023
|
Please fix the test failures. |
t2gran
force-pushed
the
otp2_immprve_gb_startup
branch
from
f4b5892 to
0bf91e5
Compare
Set a default: Whole world + Turin, Italy as center.
t2gran
force-pushed
the
otp2_immprve_gb_startup
branch
from
0bf91e5 to
086733c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5484 +/- ##
=============================================
+ Coverage 66.80% 66.84% +0.04%
- Complexity 15557 15635 +78
=============================================
Files 1806 1815 +9
Lines 69821 70096 +275
Branches 7357 7378 +21
=============================================
+ Hits 46646 46859 +213
- Misses 20718 20780 +62
Partials 2457 2457
☔ View full report in Codecov by Sentry. |
leonardehrenfried
previously approved these changes
Nov 7, 2023
optionsome
reviewed
Nov 9, 2023
src/main/java/org/opentripplanner/graph_builder/GraphBuilder.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Joel Lappalainen <[email protected]>
leonardehrenfried
approved these changes
Nov 9, 2023
optionsome
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This improve OTP graph build when the transit data is broken.
Issue
No
Unit tests
No, this only change the error messages and error handling, no tests added.
Documentation
No, doc on this.
Changelog
No - too small.
Bumping the serialization version id
No